dstandish commented on code in PR #50040:
URL: https://github.com/apache/airflow/pull/50040#discussion_r2075434167
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -326,6 +327,19 @@ def clear_task_instances(
if dr.state in State.finished_dr_states:
dr.state = dag_run_state
dr.start_date = timezone.utcnow()
+ if TYPE_CHECKING:
+ assert dag # todo: change signature so this is required
Review Comment:
i changed the signature.
there's not much point in passing dag in as a param to this function since
the TIs can be from different dags.
moreover, they can be from different serdags associated with the same dag --
and that in particular is what makes this complicated and required me to go and
use the scheduler dag bag object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
