potiuk commented on code in PR #50340:
URL: https://github.com/apache/airflow/pull/50340#discussion_r2079620755


##########
airflow-core/src/airflow/notifications/basenotifier.py:
##########
@@ -20,3 +20,11 @@
 from __future__ import annotations
 
 from airflow.sdk.bases.notifier import BaseNotifier as BaseNotifier
+from airflow.utils.deprecation_tools import add_deprecated_classes

Review Comment:
   (at least that was the intention of deprecated classes  - the idea was that 
you add:
   
   ```
   {
     `module' : {
         'Object` -> `new full import to the object`,
        ....
      } 
   }
   ```
   
   so in this case the `notifications` __init__.py should contain:
   
   ```
   { 
       "basenotifier" {
           "BaseNotifier" : "airflow.sdk.bases.notifier.BaseNotifier"
       } 
   } 
   ``
   
   This way:
   
   * all deprecation code is in `__init__.py`
   * no need to even have `basenotifier.py` module
   * which means that those deprecated modules altogether largely disappear and 
the code is only in `__init__,py` - see how it's done in other cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to