kaxil commented on code in PR #50300:
URL: https://github.com/apache/airflow/pull/50300#discussion_r2081448291
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -837,6 +839,15 @@ def wait(self) -> int:
# If it hasn't, assume it's failed
self._exit_code = self._exit_code if self._exit_code is not None else 1
+ self.update_task_state_if_needed()
+
+ # Now at the last possible moment, when all logs and comms with the
subprocess has finished, lets
+ # upload the remote logs
+ self._upload_logs()
Review Comment:
That moves it to the child process (Task Runner) instead of Supervisor
process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
