RoyLee1224 commented on code in PR #50416:
URL: https://github.com/apache/airflow/pull/50416#discussion_r2083137702
##########
airflow-core/src/airflow/ui/src/components/DurationChart.tsx:
##########
@@ -141,6 +145,24 @@ export const DurationChart = ({
}}
datasetIdKey="id"
options={{
+ onClick: (_event, elements) => {
+ const [element] = elements;
+
+ if (element && typeof element.index === "number") {
+ const entry = entries[element.index];
+
+ if (kind === "Dag Run") {
Review Comment:
I think adding Task Instance case would create duplicate navigation logic.
The `TaskRecentRuns` component (used in Tasks page) already implements
navigation using React Router's Link component
For context, the `DurationChart` component is used in two different contexts:
- In the `Overview` page for DAG Runs: we use the onClick handler in
react-chartjs-2 Bar to navigate
- In the `Tasks` page for Task Instances: the navigation is already handled
by the Link component in the TaskRecentRuns component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
