sanederchik commented on code in PR #50441:
URL: https://github.com/apache/airflow/pull/50441#discussion_r2083498262
##########
airflow-core/docs/howto/dynamic-dag-generation.rst:
##########
@@ -218,3 +217,74 @@ of the context are set to ``None``.
with DAG(dag_id=dag_id, ...):
...
+
+
+Abstraction of DAG objects generation
Review Comment:
Could you please give a link to the Optimizing chapter? I'm sorry I couldn't
find it...
Also I just got an idea - maybe it'd be better to move all of my commit to
Best practice chapter? Because it looks like my examples with your proposals
are more about clean code and DRY, not about specifically dynamic DAGs
generation. And here, in Dynamic Dag Generation chapter, I could leave an
example with generating dynamic DAG in a way I propose with the link to Best
practice.
Anyway I'd be glad to make it as you consider the best for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
