This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch v3-0-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v3-0-test by this push:
new 19b5af0a7db [v3-0-test] Skip provider tests when tests are skipped in
general (#49968) (#50614)
19b5af0a7db is described below
commit 19b5af0a7db9dc829148049f4f8630697b41baab
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Wed May 14 16:37:57 2025 +0200
[v3-0-test] Skip provider tests when tests are skipped in general (#49968)
(#50614)
When tests are skipped in general, provider tests should also
be skipped. There was a case where tests were skipped because
the change was "ui-only" - in this case "run-tests" was set to false
but the "skip-provider-tests" was set to false.
(cherry picked from commit dab52ddd8284f6a2560a6f221d72665e7a9accdd)
---
.github/workflows/ci-amd.yml | 3 ++-
dev/breeze/src/airflow_breeze/utils/selective_checks.py | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/ci-amd.yml b/.github/workflows/ci-amd.yml
index 8d93a24ccca..c55814a8a96 100644
--- a/.github/workflows/ci-amd.yml
+++ b/.github/workflows/ci-amd.yml
@@ -291,7 +291,8 @@ jobs:
packages: read
if: >
needs.build-info.outputs.skip-providers-tests != 'true' &&
- needs.build-info.outputs.latest-versions-only != 'true'
+ needs.build-info.outputs.latest-versions-only != 'true' &&
+ needs.build-info.outputs.run-tests == 'true'
with:
runners: ${{ needs.build-info.outputs.amd-runners }}
platform: "linux/amd64"
diff --git a/dev/breeze/src/airflow_breeze/utils/selective_checks.py
b/dev/breeze/src/airflow_breeze/utils/selective_checks.py
index 64836539432..ecf4b72d13d 100644
--- a/dev/breeze/src/airflow_breeze/utils/selective_checks.py
+++ b/dev/breeze/src/airflow_breeze/utils/selective_checks.py
@@ -775,6 +775,8 @@ class SelectiveChecks:
@cached_property
def run_tests(self) -> bool:
+ if self.full_tests_needed:
+ return True
if self._is_canary_run():
return True
if self.only_new_ui_files:
@@ -1221,6 +1223,8 @@ class SelectiveChecks:
return False
if self._get_providers_test_types_to_run():
return False
+ if not self.run_tests:
+ return True
return True
@cached_property
