eladkal commented on code in PR #50839:
URL: https://github.com/apache/airflow/pull/50839#discussion_r2099883932
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import
FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
Unless i am missing something users who run Airflow 3.0.0 won't be able to
update fab provider without also updating Airflow core version. This goes
against our promise of updating providers seperatly from core.
That said, I am not into the details of the moving configuration wave thus I
if it already agreed approch for this migration feel free to continue with what
was decided.
##########
providers/fab/src/airflow/providers/fab/www/app.py:
##########
@@ -56,7 +56,7 @@ def create_app(enable_plugins: bool):
from airflow.providers.fab.auth_manager.fab_auth_manager import
FabAuthManager
flask_app = Flask(__name__)
- flask_app.secret_key = conf.get("webserver", "SECRET_KEY")
+ flask_app.secret_key = conf.get("api", "SECRET_KEY")
Review Comment:
Unless i am missing something users who run Airflow 3.0.0 won't be able to
update fab provider without also updating Airflow core version. This goes
against our promise of updating providers separately from core.
That said, I am not into the details of the moving configuration wave thus I
if it already agreed approach for this migration feel free to continue with
what was decided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
