jsjasonseba commented on code in PR #50178: URL: https://github.com/apache/airflow/pull/50178#discussion_r2100572459
########## providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/base_alibaba.py: ########## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import Any, NamedTuple + +from airflow.hooks.base import BaseHook + + +class AccessKeyCredentials(NamedTuple): + """ + A NamedTuple to store Alibaba Cloud Access Key credentials. + + :param access_key_id: The Access Key ID for Alibaba Cloud authentication. + :param access_key_secret: The Access Key Secret for Alibaba Cloud authentication. + """ + + access_key_id: str + access_key_secret: str + + +class AlibabaBaseHook(BaseHook): + """ + A base hook for Alibaba Cloud-related hooks. + + This hook provides a common interface for authenticating using Alibaba Cloud credentials. + + Supports Access Key-based authentication. + + :param alibaba_cloud_conn_id: The connection ID to use when fetching connection info. + """ + + conn_name_attr = "alibabacloud_conn_id" Review Comment: It stands for alibaba cloud conn id. I didn’t choose the name. I followed the naming convention used in other existing Alibaba hooks for consistency. https://github.com/jsjasonseba/airflow/blob/8b5f0cf6666343f4c61bf67dc4d5d8a17f865ca8/providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/oss.py#L79-L82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
