nevcohen commented on code in PR #50804:
URL: https://github.com/apache/airflow/pull/50804#discussion_r2100771495
##########
airflow-core/src/airflow/config_templates/airflow_local_settings.py:
##########
@@ -236,7 +236,7 @@
**(
{
"base_log_folder": BASE_LOG_FOLDER,
- "remote_base": remote_base_log_folder,
+ "remote_base": urlsplit(remote_base_log_folder).path,
Review Comment:
Why do you need to change here too?
##########
providers/apache/hdfs/src/airflow/providers/apache/hdfs/log/hdfs_task_handler.py:
##########
@@ -94,7 +94,7 @@ def __init__(self, base_log_folder: str, hdfs_log_folder:
str, **kwargs):
self.upload_on_close = True
self.io = HdfsRemoteLogIO(
- remote_base=hdfs_log_folder,
+ remote_base=self.remote_base,
Review Comment:
Have you tested this? Does it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
