uranusjr commented on code in PR #50925: URL: https://github.com/apache/airflow/pull/50925#discussion_r2101410473
########## airflow-core/tests/unit/models/test_deadline.py: ########## @@ -94,6 +94,40 @@ def test_add_deadline(self, dagrun, session): assert result.callback == deadline_orm.callback assert result.callback_kwargs == deadline_orm.callback_kwargs + def test_add_multiple_deadlines(self, dagrun, session): Review Comment: Isn’t think essentially just testing SQLAlchemy relationship works? I don’t think we generally do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org