uranusjr commented on code in PR #50895:
URL: https://github.com/apache/airflow/pull/50895#discussion_r2101416027


##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -180,6 +181,7 @@ def _get_variable(key: str, deserialize_json: bool) -> Any:
                     import json
 
                     var_val = json.loads(var_val)
+                mask_secret(var_val, key)  # type: ignore[arg-type]

Review Comment:
   We should probably not type-ignore this but actually check the type? 
`var_val` can _technically_ be a number or even None.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to