jason810496 commented on code in PR #50934:
URL: https://github.com/apache/airflow/pull/50934#discussion_r2101693617
##########
scripts/ci/pre_commit/check_deferrable_default.py:
##########
@@ -106,8 +106,8 @@ def _fix_invalid_deferrable_default_value(module_filename:
str) -> None:
def main() -> int:
modules = itertools.chain(
- glob.glob(f"{ROOT_DIR}/airflow/**/sensors/**.py", recursive=True),
- glob.glob(f"{ROOT_DIR}/airflow/**/operators/**.py", recursive=True),
+ glob.glob(f"{ROOT_DIR}/**/sensors/**.py", recursive=True),
+ glob.glob(f"{ROOT_DIR}/**/operators/**.py", recursive=True),
Review Comment:
Should we specify the `providers` directory instead of using `**`?
I just searched the codebase, and it seems that all of them start with the
`providers` directory.
> Except for `airflow-core/src/airflow/sensors/base.py`, which does not
start with `providers`; however, it doesn't need to be checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
