gopidesupavan opened a new pull request, #51022: URL: https://github.com/apache/airflow/pull/51022
closes: #50802 Currently, logging to CloudWatch only occurs at startup—specifically, when the executor first launches and triggers a DAG. Logging functions correctly for this initial run, but fails on subsequent runs. This issue arises because the handler is implemented as a cached_property, and we call self.handler.close() during the final log upload. In the close() method, the shutdown parameter is set to True https://github.com/kislyuk/watchtower/blob/main/watchtower/__init__.py#L463, which blocks further logging and prevents logs from being uploaded to CloudWatch. Additionally, we should ensure that the stream name is explicitly assigned if it's available in the logger. Otherwise, we risk reusing a previously configured stream name, which can result in logs being written to the incorrect stream. ``` 2025-05-20 11:07:58.746 | 2025-05-20 15:07:58.746784 [warning ] /home/airflow/.local/lib/python3.12/site-packages/watchtower/__init__.py:464: WatchtowerWarning: Received message after logging system shutdown 2025-05-20 11:07:58.746 | warnings.warn("Received message after logging system shutdown", WatchtowerWarning) 2025-05-20 11:07:58.746 | [py.warnings] 2025-05-20 11:07:58.747 | 2025-05-20 15:07:58.747339 [debug ] send_request_headers.started request=<Request [b'PUT']> [httpcore.http11] 2025-05-20 11:07:58.747 | 2025-05-20 15:07:58.747506 [debug ] send_request_headers.complete [httpcore.http11] ``` Before: <img width="1522" alt="Screenshot 2025-05-23 at 23 10 47" src="https://github.com/user-attachments/assets/e1365e3f-e6ea-48d1-b4bd-dd3e03c25fbb"; /> After: <img width="1701" alt="Screenshot 2025-05-23 at 23 07 12" src="https://github.com/user-attachments/assets/7d542774-13fd-489b-b91b-af82e4e50a6e"; /> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
