guan404ming commented on code in PR #50746:
URL: https://github.com/apache/airflow/pull/50746#discussion_r2106246225
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##########
@@ -115,6 +116,7 @@ export const Logs = () => {
) : undefined}
<TaskLogContent
error={error}
+ height="600px"
Review Comment:
I use `h={"full"}` at first but the virtualization doesn't work as expected.
After multiple trials and searching, I follow the discussion
[here](https://github.com/TanStack/virtual/issues/25) to implement with adding
some flex and height related css for parent element and it works~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
