sjyangkevin commented on PR #50182: URL: https://github.com/apache/airflow/pull/50182#issuecomment-2909594188
> I think this makes sense. A few questions on the implementation: > > 1. I don’t think we need to explicitly join the association table. I believe SQLAlchemy has some tools to join the two models directly together ([such as `.any()`](https://stackoverflow.com/questions/6474989)). Can you look into this? > 2. Is it possible to merge the two events select queries into one? > 3. If the second point is not possible, is calling `extend()` OK if the two queries contain duplicates? I don’t recall how SQLAlchemy works well enough around this. It may emit a constraint conflict. Very appreciate the feedback. Your point is totally valid. 1. yes, I definitely will look into this. I also feel that the join is redundant and there may be a better way to get the asset event information. for 2.) and 3.), I have run a few testing with mixed Asset and AssetAlias, but maybe if one event is belong to both an Asset and an Alias. Will investigate more into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
