uranusjr commented on code in PR #50677:
URL: https://github.com/apache/airflow/pull/50677#discussion_r2108066688


##########
task-sdk/src/airflow/sdk/definitions/deadline_reference.py:
##########


Review Comment:
   Would it be a good idea to name this just `deadline`? This would match the 
core module, is shorter but still clear enough (I think).
   
   Also, it’s probably a good idea to expose DeadlineReference to `airflow.sdk` 
without needing to do subpackage import. It is a user-facing class, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to