kaxil opened a new pull request, #51180: URL: https://github.com/apache/airflow/pull/51180
closes https://github.com/apache/airflow/issues/50500 Adds a new safeguard for cases where the task subprocess closes before all pipe sockets send EOF. While the supervisor "shouldn't" get stuck, the reality is that under extreme load the selector can miss final EOF events - which might have happened previously under high CPU load + the bug in https://github.com/apache/airflow/pull/51023. This adds a safety net to prevent resource leaks and hanging processes (Pods accumulate for CE & KE). The timeout is generous (60s) to avoid premature cleanup of legitimate slow socket operations. I tried reproducing it reliably after my first attempt in https://github.com/apache/airflow/pull/51020 but haven't been able to reproduce it. Changes - Add `workers.socket_cleanup_timeout` config (default 60s) to force-close stuck sockets after task process exits - Improve child process socket cleanup to reduce EOF misses - Add some logs for better FD identification if this happens. Previously when I saw it, it was mainly requests & logs fd. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
