sjyangkevin commented on code in PR #50734:
URL: https://github.com/apache/airflow/pull/50734#discussion_r2114682103
##########
providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:
##########
@@ -83,6 +83,7 @@ def __init__(self, *args, **kwargs) -> None:
self.schema = kwargs.pop("schema", None)
self.local_infile = kwargs.pop("local_infile", False)
self.init_command = kwargs.pop("init_command", None)
+ self.region_name = kwargs.pop("region_name", None)
Review Comment:
Would it be possible to make this token a @cached_property. This generate
token method is invoked in a method. Wondering how often this method will be
called. If call frequently, does it generate the token every time? Does other
methods potentially use this token. If so, maybe a class attribute can benefit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
