jroachgolf84 commented on PR #51167: URL: https://github.com/apache/airflow/pull/51167#issuecomment-2920543524
> @jroachgolf84 I think the try expect block around hook.isfile, can be removed, because the exception is not raised from that call. Also I would suggest to update the test case for missing file - because at the moment its behavior depends on the the OSError, that never gets actually raised This is not the case; `.isfile` can raise the `OSError` exception. See here. https://github.com/apache/airflow/blob/1439e1f07eb17652e53bafc3b3c85f4dac5593f9/providers/sftp/src/airflow/providers/sftp/hooks/sftp.py#L220-L230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
