potiuk commented on code in PR #51237:
URL: https://github.com/apache/airflow/pull/51237#discussion_r2116045567
##########
dev/breeze/src/airflow_breeze/prepare_providers/provider_documentation.py:
##########
@@ -715,13 +716,51 @@ def _update_commits_rst(
)
+def _is_test_only_changes(pr_number: str, github_token: str | None = None) ->
bool:
Review Comment:
As discussed on slack - adding the need for GH token here is likely not a
good idea for the interactive command. We can query local git repo without
extra interaction with GH because RM already has all the commits locally - and
we have all data in "Changes" (notably commit hash).
```
class Change(NamedTuple):
full_hash: str
short_hash: str
date: str
message: str
message_without_backticks: str
pr: int | None
```
Either by pygit api or even easier by `git command`:
```
git diff
4dfc907f6bdc86a4c9bb941f61accebdc5333b13..4dfc907f6bdc86a4c9bb941f61accebdc5333b13^
--name-only
providers/fab/tests/conftest.py
providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py
```
or even `git diff 4dfc907f6bdc86a4c9bb941f61accebdc5333b13 --name-only`
No authentication needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
