o-nikolas commented on code in PR #48872:
URL: https://github.com/apache/airflow/pull/48872#discussion_r2116598130
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -92,9 +89,19 @@ class RdsCreateDbSnapshotOperator(RdsBaseOperator):
:param tags: A dictionary of tags or a list of tags in format `[{"Key":
"...", "Value": "..."},]`
`USER Tagging
<https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_Tagging.html>`__
:param wait_for_completion: If True, waits for creation of the DB
snapshot to complete. (default: True)
+ :param aws_conn_id: The Airflow connection used for AWS credentials.
Review Comment:
I think this is more about maintaining consistency with these 4 important
params. We're trying to signal to the user (and their IDE via param driven
autocompletion) what can still be done with these operators, despite those
params being moved to the super class. So for me personally, I'm still in
favour of this. But as usual, if I'm out voted we can stop doing it and go back
and remove all the places where we have (there are a LOT so that will be a a
great line count booster PR for someone :wink: )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
