Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-546640879 > So what happens if the task ran successfully first and then was cleared? Does that clear XCOM. It should IMHO. IMHO it should as well, and it does: https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L103-L107 Idempotency is guaranteed, and it is still as idempotent as before. It is even more atomic than before, as it is now being done in a single transaction. The only chance is that it is done at the end of the run, instead of the beginning. > Btw: am I correct that an alembic migration script was edited rather than a new migration was created? That will not work for upgrades. The change is fully backward compatible. The only chance is getting rid of the `id` column because that one wasn't used anywhere in the code. The index on there has been replaced by the primary key. > Also what happened to squashed commits? There is a new feature in Github that we use `squash and merge`, this will make sure that there is only one commit in the target branch. In this case: https://github.com/apache/airflow/commit/74d2a0d9e77cf90b85654f65d1adba0875e0fb1f
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
