RNHTTR commented on code in PR #51150: URL: https://github.com/apache/airflow/pull/51150#discussion_r2121204003
########## airflow-core/docs/administration-and-deployment/logging-monitoring/callbacks.rst: ########## @@ -39,26 +45,34 @@ For example, you may wish to alert when certain tasks have failed, or have the l Callback Types -------------- -There are five types of task events that can trigger a callback: +There are six types of events that can trigger a callback: =========================================== ================================================================ Name Description =========================================== ================================================================ -``on_success_callback`` Invoked when the task :ref:`succeeds <concepts:task-instances>` -``on_failure_callback`` Invoked when the task :ref:`fails <concepts:task-instances>` -``on_retry_callback`` Invoked when the task is :ref:`up for retry <concepts:task-instances>` +``on_success_callback`` Invoked when the DAG or task :ref:`succeeds <concepts:task-instances>`. Review Comment: maybe say... ``` `Invoked when the :ref:`DAG succeeds <concepts:dag-run-status>` or the :ref:`task instance succeeds concepts:task-instances>` ``` (I'm not sure if `concepts:dag-run-status>` is real, but I think you should [link here](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dag-run.html#dag-run-status)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
