o-nikolas commented on code in PR #50990:
URL: https://github.com/apache/airflow/pull/50990#discussion_r2122239161
##########
airflow-core/tests/unit/utils/test_log_handlers.py:
##########
@@ -189,12 +188,13 @@ def task_callable(ti):
assert hasattr(file_handler, "read")
log, metadata = file_handler.read(ti, 1)
assert isinstance(metadata, dict)
- target_re = re.compile(r"\A\[[^\]]+\] {test_log_handlers.py:\d+} INFO
- test\Z")
+ # Update regex pattern to match the structlog format - just check for
the word "test"
+ # in the log events since structlog format is different from the old
format
Review Comment:
This comment won't make much sense outside of the context of the PR diff.
Since you're mentioning updating the old code (the regex pattern) that won't be
present if someone is just reading the latest code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
