ashb commented on code in PR #51329:
URL: https://github.com/apache/airflow/pull/51329#discussion_r2123372796
##########
.pre-commit-config.yaml:
##########
@@ -1266,6 +1267,14 @@ repos:
files:
^airflow-ctl/src/airflowctl/api/operations.py|airflow-ctl/src/airflowctl/cli/.*\.py$
additional_dependencies: ['rich>=12.4.4']
+ - id: mockery
+ name: Generate mocks for go
+ entry: --entrypoint ./scripts/in_container/run_mockery.sh
vektra/mockery:3
Review Comment:
I think in this case it would be clearer to just have `mockery` command etc
here. The "in_container" is for when the commands do more things, but here what
we are running is very simple, so having it direct is much much easier to
understandd.
##########
.pre-commit-config.yaml:
##########
@@ -1266,6 +1267,14 @@ repos:
files:
^airflow-ctl/src/airflowctl/api/operations.py|airflow-ctl/src/airflowctl/cli/.*\.py$
additional_dependencies: ['rich>=12.4.4']
+ - id: mockery
Review Comment:
Maybe this should be `go-mocks` or `go-mockery`. WDYT?
##########
go-sdk/worker/runner.go:
##########
@@ -342,6 +342,7 @@ func (w *worker) ExecuteTaskWorkload(ctx context.Context,
workload api.ExecuteTa
EndDate: endTime,
State: api.TISuccessStatePayloadState(finalState),
})
+
Review Comment:
I'm guessing this was to have a change to trigger the pre-commit stuff,
right? Once we are happy with it can we undo this otherwise pointless change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
