gopidesupavan commented on code in PR #51279:
URL: https://github.com/apache/airflow/pull/51279#discussion_r2124499225
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -805,17 +809,8 @@ async def init_comms(self):
task_runner.SUPERVISOR_COMMS = comms_decoder
- async def connect_stdin() -> asyncio.StreamReader:
- reader = asyncio.StreamReader()
- protocol = asyncio.StreamReaderProtocol(reader)
- await loop.connect_read_pipe(lambda: protocol, sys.stdin)
- return reader
-
- self.response_sock = await connect_stdin()
-
- line = await self.response_sock.readline()
+ msg = comms_decoder.get_message()
Review Comment:
sys.stdin is already configured to comms here
https://github.com/apache/airflow/pull/51279/files#diff-e4cc497f1c786d142ce4c930f43e33b0bb4b53d375d274278fa82f4d5567608aR805.
I think its fine to read from get_message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
