Prab-27 commented on PR #51398:
URL: https://github.com/apache/airflow/pull/51398#issuecomment-2939929428

   @bugraoz93 Could you please check if this is a proper fix or not ? 
   
   If we use `self.save()` - it will show 
   ```
   airflowctl auth login --api-url="http://localhost:28080"; --username=admin 
--password
   Password:
   ```
   ```
   Traceback (most recent call last):
     File "/usr/local/bin/airflowctl", line 10, in <module>
       sys.exit(main())
     File "/opt/airflow/airflow-ctl/src/airflowctl/__main__.py", line 34, in 
main
       safe_call_command(args.func, args=args)
     File "/opt/airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py", line 65, 
in safe_call_command
       function(args)
     File "/opt/airflow/airflow-ctl/src/airflowctl/ctl/cli_config.py", line 56, 
in command
       return func(*args, **kwargs)
     File "/opt/airflow/airflow-ctl/src/airflowctl/api/client.py", line 308, in 
wrapper
       with get_client(kind=kind) as api_client:
     File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__
       return next(self.gen)
     File "/opt/airflow/airflow-ctl/src/airflowctl/api/client.py", line 276, in 
get_client
       credentials = Credentials(client_kind=kind).load()
     File "/opt/airflow/airflow-ctl/src/airflowctl/api/client.py", line 144, in 
load
       self.save()
     File "/opt/airflow/airflow-ctl/src/airflowctl/api/client.py", line 134, in 
save
       keyring.set_password("airflowctl", f"api_token-{self.api_environment}", 
self.api_token)
     File "/usr/local/lib/python3.9/site-packages/keyring/core.py", line 68, in 
set_password
       get_keyring().set_password(service_name, username, password)
     File "/usr/local/lib/python3.9/site-packages/keyring/backend.py", line 60, 
in wrapper
       return orig(self, system, username, *args, **kwargs)
     File "/usr/local/lib/python3.9/site-packages/keyring/backends/chainer.py", 
line 56, in set_password
       return keyring.set_password(service, username, password)
     File "/usr/local/lib/python3.9/site-packages/keyring/backend.py", line 60, 
in wrapper
       return orig(self, system, username, *args, **kwargs)
     File "/usr/local/lib/python3.9/site-packages/keyring/backend.py", line 60, 
in wrapper
       return orig(self, system, username, *args, **kwargs)
     File "/usr/local/lib/python3.9/site-packages/keyrings/alt/file_base.py", 
line 120, in set_password
       raise TypeError("Password should be a unicode string, not bytes.")
   TypeError: Password should be a unicode string, not bytes
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to