Copilot commented on code in PR #51406:
URL: https://github.com/apache/airflow/pull/51406#discussion_r2131789311
##########
airflow-core/src/airflow/dag_processing/collection.py:
##########
@@ -254,51 +261,65 @@ def _update_import_errors(
session.execute(
delete(ParseImportError).where(
- ParseImportError.filename.in_(list(files_parsed)),
ParseImportError.bundle_name == bundle_name
+ tuple_(ParseImportError.bundle_name,
ParseImportError.filename).in_(list(files_parsed))
)
)
existing_import_error_files = set(
- session.execute(select(ParseImportError.filename,
ParseImportError.bundle_name))
+ session.execute(select(ParseImportError.bundle_name,
ParseImportError.filename))
Review Comment:
[nitpick] Since the update now relies on matching tuple keys from the
database with those in import_errors, consider adding an inline comment
explaining the expected structure of the results for clarity and future
maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
