ashb commented on code in PR #51153: URL: https://github.com/apache/airflow/pull/51153#discussion_r2132103707
########## task-sdk/pyproject.toml: ########## @@ -213,3 +213,6 @@ pythonpath = "tests" # Keep temporary directories (created by `tmp_path`) for 2 recent runs only failed tests. tmp_path_retention_count = "2" tmp_path_retention_policy = "failed" + +[project.optional-dependencies] +docs = ["apache-airflow-devel-common[docs]"] Review Comment: Nit: this should be around L 146 so it's with the other deps Additionally this should be a `dependency-groups`, as it doesn't ever make sense for a user to do `pip install "apache-airflow-task-sdk[docs]"` (which is what optional deps allows) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
