Lee-W commented on code in PR #51513:
URL: https://github.com/apache/airflow/pull/51513#discussion_r2134892898
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/operators/maxcompute.py:
##########
@@ -72,7 +72,7 @@ class MaxComputeSQLOperator(BaseOperator):
"aliases",
"default_schema",
"quota_name",
- "alibabacloud_conn_id",
+ "maxcompute_conn_id",
Review Comment:
do you know whether this change has been released or not?
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/maxcompute.py:
##########
@@ -45,7 +45,7 @@ def fallback_to_default_project_endpoint(func: Callable[...,
RT]) -> Callable[..
def inner_wrapper(self, **kwargs) -> RT:
required_args = ("project", "endpoint")
for arg_name in required_args:
- kwargs[arg_name] = kwargs.get(arg_name, getattr(self, arg_name))
+ kwargs[arg_name] = getattr(self, arg_name) if kwargs.get(arg_name)
is None else kwargs[arg_name]
Review Comment:
we probably could add a comment here. I think someone in the future would
most likely want to change it back by accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
