potiuk commented on PR #51322: URL: https://github.com/apache/airflow/pull/51322#issuecomment-2955934456
> > I really do wonder if this level of complexity means it's time to move away from uni to something with more structure such as TOML > > @ashb, > > Yeah, that was discussed in the AIP, but I actually think this is much easier and simpler honestly: > > 1. It's _way_ fewer changes both strictly lines of code and as well as cognitively for users. > 2. For those who are not using multi-team, nothing will change and their configuration as they have it continues to work. To overhaul all of config, just to enable the users who wish to use multi-team, feels like putting a lot of work onto developers and users of airflow who are not interested in multi team (which will be a much bigger population). > 3. Also, I like the separation of team and non-team config. To make config expressive enough to mix the two doesn't actually seem to gain anything to me, I prefer the separation of church and state :) Quite agree. The thing is also that for multi-team configuration we do not want team a configuration to be present in DAG file processor of Team B. You keep various things there including credentials needed for secrets manager (future) - so you do not want to give Team A a way to read Team B credentials - so you just do not want team A config to be present in Team B environment. Having the config split by file was deliberate choice - because then you could only copy the dedicated config file to dedicated environment. If we use TOML and arrays, you woudl have to likely pre-process the config files and generate differet config sets for different teams, which would mean additional operational complexity when updating config files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
