kacpermuda opened a new pull request, #51542:
URL: https://github.com/apache/airflow/pull/51542
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Few fixes included in this PR:
1. `SnowflakeSqlApiHook.execute_query` will now consistently reset query_ids
each time it's called. Now the behavior depended on number of queries executed,
which could cause getting query_ids from previous execution as an attribute.
2. `SnowflakeSqlApiTrigger` will now return the query_ids of query actually
executed, instead of child query_ids of multi-statement queries, which is
consistent with non-deferrable behavior that we have right now. This change
makes the behavior consistent regardless of execution mode.
3. I've added re-assignment of query_ids after coming back from deferral in
`SnowflakeSqlApiOperator`, so that the listeners can use that information and
have consistent behavior regardless of execution mode.
4. I've added an explicit caching of `SnowflakeSqlApiHook` in
`SnowflakeSqlApiOperator`, right now the property of super class
`SQLExecuteQueryOperator` was overwritten during execution, which could lead to
inconsistencies, depending on when you ask for `SnowflakeSqlApiOperator._hook`.
5. Added missing `self.query_ids` definition in init of
`SnowflakeSqlApiOperator`
Added tests for all changes.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
