pierrejeambrun commented on code in PR #51548:
URL: https://github.com/apache/airflow/pull/51548#discussion_r2138128239
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -59,6 +61,12 @@ def get_configs() -> ConfigResponse:
"external_log_name": getattr(task_log_reader.log_handler, "log_name",
None),
}
+ plugins_manager.initialize_flask_plugins()
Review Comment:
```suggestion
```
Not needed, this is done at the bootstrap of the application in
`init_flask_plugins`
##########
airflow-core/src/airflow/ui/src/layouts/Nav/PluginMenus.tsx:
##########
@@ -21,33 +21,29 @@ import { useTranslation } from "react-i18next";
import { FiChevronRight } from "react-icons/fi";
import { LuPlug } from "react-icons/lu";
-import { usePluginServiceGetPlugins } from "openapi/queries";
import type { AppBuilderMenuItemResponse } from "openapi/requests/types.gen";
+import { useConfig } from "src/queries/useConfig";
import { Menu } from "src/components/ui";
import { NavButton } from "./NavButton";
export const PluginMenus = () => {
const { t: translate } = useTranslation("common");
- const { data } = usePluginServiceGetPlugins();
+ const menuItems = useConfig("plugins_extra_menu_items") as
Array<AppBuilderMenuItemResponse> | undefined;
Review Comment:
Do we need that hard casting? Normally this should be the correct type
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
