uranusjr commented on code in PR #51535:
URL: https://github.com/apache/airflow/pull/51535#discussion_r2139530422
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:
##########
@@ -69,41 +68,41 @@ def get_xcom_entry(
stringify: Annotated[bool, Query()] = False,
) -> XComResponseNative | XComResponseString:
"""Get an XCom entry."""
- if deserialize:
- if not conf.getboolean("api", "enable_xcom_deserialize_support",
fallback=False):
- raise HTTPException(
- status.HTTP_400_BAD_REQUEST, "XCom deserialization is disabled
in configuration."
- )
- query = select(XComModel, XComModel.value)
- else:
- query = select(XComModel)
-
- query = query.where(
- XComModel.dag_id == dag_id,
- XComModel.task_id == task_id,
- XComModel.key == xcom_key,
- XComModel.map_index == map_index,
+ xcom_query = XComModel.get_many(
+ run_id=dag_run_id,
+ key=xcom_key,
+ task_ids=task_id,
+ dag_ids=dag_id,
+ map_indexes=map_index,
+ session=session,
+ limit=1,
)
- query = query.join(DR, and_(XComModel.dag_id == DR.dag_id,
XComModel.run_id == DR.run_id))
- query = query.where(DR.run_id == dag_run_id)
- query =
query.options(joinedload(XComModel.dag_run).joinedload(DR.dag_model))
- if deserialize:
- item = session.execute(query).one_or_none()
- else:
- item = session.scalars(query).one_or_none()
+ # We use `BaseXCom.get_many` to fetch XComs directly from the database,
bypassing the XCom Backend.
+ # This avoids deserialization via the backend (e.g., from a remote storage
like S3) and instead
+ # retrieves the raw serialized value from the database.
+ result = xcom_query.limit(1).first()
- if item is None:
+ if result is None:
raise HTTPException(status.HTTP_404_NOT_FOUND, f"XCom entry with key:
`{xcom_key}` not found")
+ item = copy.copy(result)
Review Comment:
Ah now I notice there’s an assignment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
