kesem0811 commented on code in PR #51080:
URL: https://github.com/apache/airflow/pull/51080#discussion_r2140088435
##########
helm-tests/tests/helm_tests/security/test_scc_rolebinding.py:
##########
@@ -61,6 +61,29 @@ def test_create_scc(self, rbac_enabled, scc_enabled,
created):
assert jmespath.search("subjects[7].name", docs[0]) ==
"release-name-airflow-create-user-job"
assert jmespath.search("subjects[8].name", docs[0]) ==
"release-name-airflow-cleanup"
+ @pytest.mark.parametrize(
+ "dag_processor_enabled",
+ [
+ (True),
+ (False),
+ ],
+ )
+ def test_scc_subjects_include_dag_processor(self, dag_processor_enabled):
Review Comment:
Thanks for your review!
I’ve removed the new test and validated that the existing tests still cover
the behavior.
I also considered changing the default to False, but doing so caused many
other tests to fail. Since the DAG processor will always be enabled in Airflow
3, I believe changing the default value isn't necessary at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
