bbovenzi commented on code in PR #51146:
URL: https://github.com/apache/airflow/pull/51146#discussion_r2143236170
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##########
@@ -94,17 +100,19 @@ export const Logs = () => {
return (
<Box display="flex" flexDirection="column" h="100%" p={2}>
<TaskLogHeader
+ expanded={expanded}
onSelectTryNumber={onSelectTryNumber}
sourceOptions={data.sources}
taskInstance={taskInstance}
+ toggleExpanded={toggleExpanded}
toggleFullscreen={toggleFullscreen}
toggleWrap={toggleWrap}
tryNumber={tryNumber}
wrap={wrap}
/>
{showExternalLogRedirect && externalLogName && taskInstance ? (
tryNumber === undefined ? (
- <p>No try number</p>
+ <p>{translate("No try number")}</p>
Review Comment:
Let's rebase and use the correct translate here.
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##########
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
</Select.Content>
</Select.Root>
) : undefined}
- <HStack>
+ <HStack gap={1}>
<Tooltip closeDelay={100} content="Press w to toggle wrap"
openDelay={100}>
<Button
+ _hover={{ bg: "bg.emphasized" }}
aria-label={wrap ? "Unwrap" : "Wrap"}
- bg="bg.panel"
+ bg="black"
+ color="white"
+ m={0}
onClick={toggleWrap}
+ px={4}
+ py={2}
variant="outline"
>
{wrap ? "Unwrap" : "Wrap"}
</Button>
</Tooltip>
+ <Tooltip closeDelay={100} content="Press e to expand/collapse"
openDelay={100}>
+ <ButtonGroup attached size="md" variant="outline">
+ <IconButton
+ aria-label="Expand"
Review Comment:
The aria-labels can also call `translate()`
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##########
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
</Select.Content>
</Select.Root>
) : undefined}
- <HStack>
+ <HStack gap={1}>
<Tooltip closeDelay={100} content="Press w to toggle wrap"
openDelay={100}>
<Button
+ _hover={{ bg: "bg.emphasized" }}
aria-label={wrap ? "Unwrap" : "Wrap"}
- bg="bg.panel"
+ bg="black"
+ color="white"
Review Comment:
Let's remove these or pass `"bg"` and `"fg"` so that it isnt black in light
mode too
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogHeader.tsx:
##########
@@ -178,20 +183,57 @@ export const TaskLogHeader = ({
</Select.Content>
</Select.Root>
) : undefined}
- <HStack>
+ <HStack gap={1}>
<Tooltip closeDelay={100} content="Press w to toggle wrap"
openDelay={100}>
<Button
+ _hover={{ bg: "bg.emphasized" }}
aria-label={wrap ? "Unwrap" : "Wrap"}
- bg="bg.panel"
+ bg="black"
+ color="white"
+ m={0}
onClick={toggleWrap}
+ px={4}
+ py={2}
variant="outline"
>
{wrap ? "Unwrap" : "Wrap"}
</Button>
</Tooltip>
+ <Tooltip closeDelay={100} content="Press e to expand/collapse"
openDelay={100}>
Review Comment:
Let's translate the tooltip content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
