potiuk commented on PR #51537: URL: https://github.com/apache/airflow/pull/51537#issuecomment-2969784821
> Do we want this script to be runnable with breeze command? Maybe be automatically commented with output on PRs that modify translations? No need. With `uv` and `uv run` we do not need breeze to run it. For standalone scripts that do one thing, there is no neeed to have the whole breeze environment setup. > Maybe be automatically commented with output on PRs that modify translations? For the moment - as described in the process - it's more of a tool helpful for translators (to help with incremental adding of translations) and for release managers to see how much translation is left. As explained in the process - it's difficult to make it automaticly "fail" or otherwise signal translator that things are missing. Because it's the "english" translation change that will immediately make all the other translations "missing" things. Things in translation will get "missing" without involvment of the translators and it requires work of all translators to "fix" them independently. So automation in PR does not help much on PR level. What we already have have is "pre-commit" to check if there are any TODO: left. in translation after they were added with the `--add-missing`. But if someone figures a better way of automating it and workflow that can be applied here - yep, it could be used as part of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
