ephraimbuddy commented on PR #50371:
URL: https://github.com/apache/airflow/pull/50371#issuecomment-2969785085

   > Correct me if I’m wrong, but when I traced the code, it appears that 
`proc: Self = super().start()` fork parent process to create the child process. 
If the goal of the pre-import is to load modules in the parent before forking, 
it might make more sense to place it before the `proc: Self = super().start`.
   > 
   > ```js
   > DagFileProcessorManager.run()
   > └─ run_parsing_loop()
   >    └─ while loop:
   >       └─ start_new_processes()
   >             └─ create_process(dag_path) 
   >                └─ DagFileProcessorProcess.start()
   >                    └─ proc: Self = super().start(target=target, 
client=client, **kwargs) //fork
   > ```
   
   Your trace is right but I feel, we should have a verifiable reason to 
implement the pre-import. If you can spend some time and showcase the issue, I 
believe it'll help all of us in finding the reason to re-implement this 
pre-import


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to