potiuk commented on PR #51738: URL: https://github.com/apache/airflow/pull/51738#issuecomment-2973587507
> > If we already have it in the audit log could we extract it from there in the ui/api instead of adding it to dag run table?na > > Fiddeling this out of the audit log is also the workaround we use today (any maybe multiple others as well). I think this adds un-needed complexity and also we saw cases where audit log is gone after some time but the run is kept. I think we can afford another field in the DB for this. Note that the 512 char limit is only to align to definition of user in FAB, I assume usually the string is way shorter. Agree. In this case convenience of use is very important and it's. been asked many, many, many times to not only retrieve it easily but also be able to display it in the UI and act on it - (if triggering_user == 'x' do something) . Yep - we could probably add something to dynamically retrieve it from audit log, but IMHO audit log's purpose should be only to provide audit logs - I can even imagine that somoene might do automated transfer of audit logs to external system (i.e. put a trigger in a log table to automatically send every audit log to "append-only-no-delete" system (and possibly clean up audit log from the DB). I think we should not really base any logic (except displaying the logs) on the fact that audit logs are present. For me audit log is not really part of the "application schema". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
