ashb commented on code in PR #51699:
URL: https://github.com/apache/airflow/pull/51699#discussion_r2150419376
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -102,18 +101,16 @@ class DagFileParsingResult(BaseModel):
def _parse_file_entrypoint():
import structlog
- from airflow.sdk.execution_time import task_runner
+ from airflow.sdk.execution_time import comms, task_runner
# Parse DAG file, send JSON back up!
- comms_decoder = task_runner.CommsDecoder[ToDagProcessor, ToManager](
- input=sys.stdin,
- decoder=TypeAdapter[ToDagProcessor](ToDagProcessor),
+ comms_decoder = comms.CommsDecoder[ToDagProcessor, ToManager](
+ body_decoder=TypeAdapter[ToDagProcessor](ToDagProcessor),
)
- msg = comms_decoder.get_message()
+ msg = comms_decoder._get_response()
Review Comment:
Because for this very first message (and only in this case) the
parent/supervisor sends this information unsolicited
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -301,18 +296,24 @@ def _handle_request(self, msg: ToManager, log:
FilteringBoundLogger) -> None: #
resp = self.client.variables.delete(msg.key)
else:
log.error("Unhandled request", msg=msg)
+ self.send_msg(
+ None,
+ in_response_to=req_id,
Review Comment:
Could do, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
