brancof commented on PR #51814: URL: https://github.com/apache/airflow/pull/51814#issuecomment-2978456615
> Wasn't the dag processor part resolved in #51080 ? Kinda @eladkal, it depended on whether the `.Values.dagProcessor.enabled` was set or not. By default, the `.Values.dagProcessor.enabled` is `~` or nil, so in the block - [ref](https://github.com/apache/airflow/blob/36374870a128a414c02e6afd991fb0df5f7408cf/chart/templates/rbac/security-context-constraint-rolebinding.yaml#L93), it will never be templated as expected: ```yaml {{- if .Values.dagProcessor.enabled }} - kind: ServiceAccount name: {{ include "dagProcessor.serviceAccountName" . }} namespace: "{{ .Release.Namespace }}" {{- end }} ``` To solve this we need to apply the same logic that’s used in the deployment and service account conditions for the DAG Processor - [ref](https://github.com/apache/airflow/blob/f2a48f87aa2b574cd4112d69fa97899ada271b8e/chart/templates/dag-processor/dag-processor-deployment.yaml#L23). I may have gone too far in trying to make it as DRY as possible, but this might prevent problems like this one in the future. --- To test this, just set `rbac.createSCCRoleBinding: true`, and use all the default values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
