ashb commented on code in PR #51699:
URL: https://github.com/apache/airflow/pull/51699#discussion_r2151842567
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -266,20 +263,18 @@ def _on_child_started(
msg = DagFileParseRequest(
file=os.fspath(path),
bundle_path=bundle_path,
- requests_fd=self._requests_fd,
callback_requests=callbacks,
)
- self.send_msg(msg)
+ self.send_msg(msg, request_id=0)
- def _handle_request(self, msg: ToManager, log: FilteringBoundLogger) ->
None: # type: ignore[override]
+ def _handle_request(self, msg: ToManager, log: FilteringBoundLogger,
req_id: int) -> None: # type: ignore[override]
from airflow.sdk.api.datamodels._generated import ConnectionResponse,
VariableResponse
resp: BaseModel | None = None
dump_opts = {}
if isinstance(msg, DagFileParsingResult):
self.parsing_result = msg
- return
- if isinstance(msg, GetConnection):
+ elif isinstance(msg, GetConnection):
Review Comment:
It is correct. Part of the change in this is that _every_ message must send
a response, even if that response is empty. (It's wrapped up in a
`_ResponseFrame`, where body can be None by`self.send_msg`. But we must send
something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
