pierrejeambrun commented on code in PR #51714:
URL: https://github.com/apache/airflow/pull/51714#discussion_r2152280196


##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/config.py:
##########
@@ -35,3 +36,4 @@ class ConfigResponse(BaseModel):
     dashboard_alert: list[UIAlert]
     show_external_log_redirect: bool
     external_log_name: str | None = None
+    plugins_extra_menu_items: list[AppBuilderMenuItemResponse] | None = None

Review Comment:
   This can never be None.
   
   Once the plugin manager is initialized all its `None` attributes will be 
replaced with an empty list. (you can force ignore the mypy error by hard 
casting or adding a comment)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to