DinGo4DEV commented on PR #51718: URL: https://github.com/apache/airflow/pull/51718#issuecomment-2981190127
> Thanks for the PR! > After your change, the usage is much clear. > > IMO, we should also update the `KafkaMessageQueueProvider` to reduce the inconsistency on both sides. > > We could reuse your `get_kafka_queue_uri` in `KafkaMessageQueueProvider.trigger_kwargs` as well. @jason810496 TIA. ACK. I think we might still need to keep the feasibility for the direct access `MessageQueueTrigger`. And we can move the function to `utils` file/folder for better readability. Perhaps should we open new PRs for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
