choo121600 commented on PR #51735: URL: https://github.com/apache/airflow/pull/51735#issuecomment-2984821551
@pierrejeambrun ### Changes related to ESLint and rule scoping: - Explicitly added `public/i18n/locales/**/*.json` to the files field in i18nRules. → Since translation files are always located here, making it explicit improves clarity and maintainability. - Fixed JSON parsing for i18nRules by setting up `jsonc-eslint-parser`, since ESLint cannot parse .json files by default. → If there's a better alternative for handling JSON linting, I’d be happy to hear your suggestions. - Scoped typescriptRules to `files: ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"]`. → Previously, the rule was unintentionally applied to files like .json, causing unnecessary errors. Restricting it ensures proper application. - Removed `public/i18n/locales/**/*.json` from the global ignores list and handled it explicitly within i18nRules. → This path was previously ignored to avoid pre-commit errors, but I overlooked its impact on i18nRules. Now that the issue is resolved, I’ve reverted the ignore and confirmed that linting works as expected.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
