Jasperora commented on code in PR #51946:
URL: https://github.com/apache/airflow/pull/51946#discussion_r2159319451
##########
airflow-core/src/airflow/ui/src/layouts/Details/DetailsLayout.tsx:
##########
@@ -79,6 +81,24 @@ export const DetailsLayout = ({ children, error, isLoading,
tabs }: Props) => {
<Toaster />
<BackfillBanner dagId={dagId} />
<Box flex={1} minH={0}>
+ {isRightPanelCollapsed ? (
+ <IconButton
+ aria-label="Show details panel"
Review Comment:
Thank you very much for your guidance regarding translations. I would like
to confirm the correct process for adding new translation keys. Here are my
current steps and some questions:
- In `DetailsLayout.tsx`, I plan to use
`aria-label={translate("collapseDetailsPanel")}` and
`aria-label={translate("showDetailsPanel")}`.
- Take English and traditional Chinese for example, I intend to add
translations in the respective folders:
`airflow-core/src/airflow/ui/src/i18n/locales/en` and
`airflow-core/src/airflow/ui/src/i18n/locales/zh-TW`.
For example:
```
"collapseDetailsPanel": "Collapse Details Panel",
"showDetailsPanel": "Show Details Panel"
```
and
```
"collapseDetailsPanel": "收合詳細資訊",
"showDetailsPanel": "展開詳細資訊"
```
However, I am unsure which file within these folders (e.g. `common.json`) is
the most appropriate place to add these keys to ensure consistency with the
existing format.
Additionally, for languages that I am not familiar with, what is the
recommended approach for handling those translations?
Feel free to tell me if I missed some steps. Thank you in advance for your
advice and understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
