jscheffl commented on issue #51977:
URL: https://github.com/apache/airflow/issues/51977#issuecomment-2994200590
No, still I believe we should not change the way we handle the default.
Still you do not need to provide a Default to the Params object. then you
can `.get('key', 'default')`.
But if you see how it is used in the docs in
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/params.html
in the first example... if the default is NOT given as today it will break the
example as in `dag.log.info(dag.params['my_int_param'])` with a Key Error.
As we did this for a long long time as an example I would see this a
breaking change for a couple of Dag authors which would after the change
potentially run into a KeyError which worked before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
