pierrejeambrun commented on issue #51878: URL: https://github.com/apache/airflow/issues/51878#issuecomment-2996553777
Hi @kevinhongzl, Thanks a lot for your investigation. I think that the important metric is the size of the icons lib relative to the rest of the bundle, independently if we're looking at those metrics before or after tree shaking. In your example `45kb` for the react-icons part, but what is the total bundle size ? Also we shouldn't have that many icons lib shipped in the project, we don't need all of that and sticking to only one should be better. I think it's worth continuing the effort. (unless the size of the icons is really insignificant relatively to the bundle size, but it shouldn't) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
