bdsoha commented on code in PR #52184:
URL: https://github.com/apache/airflow/pull/52184#discussion_r2165806489
##########
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py:
##########
@@ -73,12 +75,24 @@ def force_use_internal_api_on_edge_worker():
# export Edge API to be used for internal API
os.environ["_AIRFLOW__SKIP_DATABASE_EXECUTOR_COMPATIBILITY_CHECK"] = "1"
os.environ["AIRFLOW_ENABLE_AIP_44"] = "True"
- if "airflow" in sys.argv[0] and sys.argv[1:3] == ["edge", "worker"]:
- api_url = conf.get("edge", "api_url")
- if not api_url:
- raise SystemExit("Error: API URL is not configured, please correct
configuration.")
- logger.info("Starting worker with API endpoint %s", api_url)
- os.environ["AIRFLOW__CORE__INTERNAL_API_URL"] = api_url
+ if not ("airflow" in sys.argv[0] and sys.argv[1:3] == ["edge", "worker"]):
+ return
+
+ api_url = conf.get("edge", "api_url")
+ if not api_url:
+ raise SystemExit("Error: API URL is not configured, please correct
configuration.")
+ logger.info("Starting worker with API endpoint %s", api_url)
+ os.environ["AIRFLOW__CORE__INTERNAL_API_URL"] = api_url
+
+ if not AIRFLOW_V_3_0_PLUS:
+ return
+
+ execution_api_server_url = conf.get("core", "execution_api_server_url")
Review Comment:
I will have a look, maybe I'll set a fallback.
Also noticed that the same should be true for `api_url`:
https://github.com/apache/airflow/blob/67353352c3e2635c3fb9d1f711e9e1d58daba7e4/providers/edge3/src/airflow/providers/edge3/cli/edge_command.py#L77-L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
