pierrejeambrun commented on code in PR #52257:
URL: https://github.com/apache/airflow/pull/52257#discussion_r2167089501
##########
airflow-core/src/airflow/ui/src/pages/Security.tsx:
##########
@@ -43,14 +43,16 @@ export const Security = () => {
return <ErrorPage />;
}
+ /* eslint-disable react/iframe-missing-sandbox */
return (
<Box flexGrow={1} m={-3}>
<iframe
- sandbox="allow-same-origin allow-forms"
+ sandbox="allow-scripts allow-same-origin allow-forms"
Review Comment:
Yes, the embedded document is trusted, even if it has the ability to remove
the sandbox attribute, it shouldn't do it.
##########
airflow-core/src/airflow/ui/src/vite-env.d.ts:
##########
@@ -19,6 +19,7 @@
*/
/// <reference types="vite/client" />
+/// <reference types="vite/types/importMeta.d.ts" />
Review Comment:
Can you explain why this is needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
